XCM coretime region transfers #3455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The benchmark for the coretime chain should be re-run since the weight is currently set to |
8 tasks
bkontur
reviewed
Mar 5, 2024
cumulus/parachains/runtimes/coretime/coretime-rococo/src/lib.rs
Outdated
Show resolved
Hide resolved
cumulus/parachains/runtimes/coretime/coretime-rococo/src/lib.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
seadanda
added
T6-XCM
|
Review required! Latest push from author must always be reviewed |
|
Would be great if we could get this merged soon :) |
bkontur
approved these changes
Apr 16, 2024
seadanda
approved these changes
Apr 16, 2024
Merged
via the queue into
paritytech:master
with commit Apr 17, 2024
e6f3106
133 of 137 checks passed
@Szegoo @seadanda waiting here: #4396 (comment) |
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 7, 2024
Addressing comment: #3455 (comment) --------- Co-authored-by: command-bot <>
paritytech-ci
pushed a commit
that referenced
this pull request
May 8, 2024
Addressing comment: #3455 (comment) --------- Co-authored-by: command-bot <>
This was referenced Jun 5, 2024
hitchhooker
pushed a commit
to ibp-network/polkadot-sdk
that referenced
this pull request
Jun 5, 2024
Addressing comment: paritytech#3455 (comment) --------- Co-authored-by: command-bot <>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 26, 2024
The problem with the current implementation is that minting will cause the region coremask to be set to `Coremask::complete` regardless of the actual coremask. This PR fixes that. More details about the nonfungible implementation can be found here: #3455 --------- Co-authored-by: Dónal Murray <donalm@seadanda.dev> Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
Addressing comment: paritytech#3455 (comment) --------- Co-authored-by: command-bot <>
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
The problem with the current implementation is that minting will cause the region coremask to be set to `Coremask::complete` regardless of the actual coremask. This PR fixes that. More details about the nonfungible implementation can be found here: paritytech#3455 --------- Co-authored-by: Dónal Murray <donalm@seadanda.dev> Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces changes enabling the transfer of coretime regions via XCM.
TL;DR: There are two primary issues that are resolved in this PR:
mintandburnfunctions were not implemented for coretime regions. These operations are essential for moving assets to and from the XCM holding register.Weight::Max, effectively preventing its execution.mint_intoandburnimplementationThis PR addresses the issue with cross-chain transferring regions back to the Coretime chain. Remote reserve transfers are performed by withdrawing and depositing the asset to and from the holding registry. This requires the asset to support burning and minting functionality.
This PR adds burning and minting; however, they work a bit differently than usual so that the associated region record is not lost when burning. Instead of removing all the data, burning will set the owner of the region to
None, and when minting it back, it will set it to an actual value. So, when cross-chain transferring, withdrawing into the registry will remove the region from its original owner, and when depositing it from the registry, it will set its owner to another accountThis was originally implemented in this PR: #3455, however we decided to move all of it to this single PR (#3455 (comment))
Fixes made in this PR
XcmReserveTransferFilteron coretime chain since it is meant as a reserve chain for coretime regions.AssetTransactorinstead of assumingpallet-balancesfor fungible transfers.Weight::max().Closes: #865